My favorite will always be Arcanine. I didnt use him until i played leaf green but hes ferocious looking plus hes REALLY powerful with physical attacks and fire ones.
A recent favorite has been Steelix, partly because he can take like 20 hits and lose 30 health AND cause when he follows you he's so big he's not allowed inside buildings.